RFR: JDK-8234689 facilitate writing additional custom attributes in a class file

[Jonathan Gibbons]

Rémi,

Thanks; I didn't know of that small group of functions.  I've already pushed the code. I doubt there's any noticeable
performance difference, but now would be a good time to fix it.

-- Jon


On 12/09/2019 02:07 PM, Remi Forax wrote:
> Function<Symbol, Integer> should be a ToIntFunction<? super Symbol> to avoid boxing the return value from int to Integer,
> otherwise looks good.
>
> Rémi
>
> ----- Mail original -----
>> De: "jan lahoda" <jan.lahoda at oracle.com>
>> À: "jonathan gibbons" <jonathan.gibbons at oracle.com>, "compiler-dev" <compiler-dev at openjdk.java.net>
>> Envoyé: Lundi 9 Décembre 2019 20:20:48
>> Objet: Re: RFR: JDK-8234689 facilitate writing additional custom attributes in a class file
>> Looks good to me.
>>
>> Thanks,
>>      Jan
>>
>> On 06. 12. 19 23:10, Jonathan Gibbons wrote:
>>> Updated webrev:
>>>
>>> Webrev: http://cr.openjdk.java.net/~jjg/8234689/webrev.01/
>>>
>>> -- Jon
>>>
>>>
>>> On 12/06/2019 01:19 PM, Jonathan Gibbons wrote:
>>>> Hi Jan,
>>>>
>>>> Yes, it did occur to me after the fact that we could keep the existing
>>>> method if we wanted to.  I'll put it back and update the test.
>>>>
>>>> -- Jon
>>>>
>>>>
>>>> On 12/05/2019 11:57 PM, Jan Lahoda wrote:
>>>>> Overall looks OK to me. Not sure if it would make sense to keep the
>>>>> existing method? The test will need tweaks for @bug and @summary.
>>>>>
>>>>> Jan
>>>>>
>>>>> On 06. 12. 19 3:23, Jonathan Gibbons wrote:
>>>>>> Please review a small change to javac to permit friendly clients to
>>>>>> inject additional attributes into a class file.
>>>>>>
>>>>>> This supersedes and generalizes an existing mechanism which is
>>>>>> difficult/impractical to use, especially
>>>>>> in current versions of javac where split packages are strongly
>>>>>> discouraged.
>>>>>>
>>>>>> -- Jon
>>>>>>
>>>>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8234689
>>>>>> Webrev: http://cr.openjdk.java.net/~jjg/8234689/webrev.00/
>>>>>>