JDK 15 RFR: JDK-8225361 : Start of release updates for JDK 15, includes JDK-8235497 and JDK-8235528

[Joe Darcy]

Thanks for the review.

On 12/9/2019 5:20 PM, Jonathan Gibbons wrote:
> The comment for 14 could be updated, in
> http://cr.openjdk.java.net/~darcy/8225361.5/src/jdk.compiler/share/classes/com/sun/tools/javac/code/Source.java.sdiff.html 
>
> or else (later) we should just simplify/drop these comments and rely 
> on Source.Feature which is inherently more accurate.


I'll update that enum constant to use similar wording as SourceVersion:


   63      *  14: switch expressions (pattern matching and records in
   64      *      preview, text blocks in preview again)
   65      *  15: TBD

http://cr.openjdk.java.net/~darcy/8225361.5/src/java.compiler/share/classes/javax/lang/model/SourceVersion.java.frames.html

The descriptions in the javax.lang.model.SourceVersion and javac Source 
enums are not always consistently updated when new language features go 
back.


>
> Changes in this file do not seem to be directly version related:
> test/langtools/tools/javac/records/RecordMemberTests.java


I added the second string argument to the assert methods to provide some 
additional debugging information; the tests were failing in earlier 
iterations before some corrections were made to the records support 
under 15 vs 14. I think these changes give better information in the 
case of test failures so I'd prefer to leave them in.


>
> I've not looked in detail at the contents of the make/data/symbols files.

Acknowledged; those files will need to be updated at least once to 
accommodate API changes subsequent to JDK 14 b26, including records and 
the removal of pack200 which are both post-b26.

Cheers,

-Joe



>
> -- Jon
>
> On 12/6/19 10:32 PM, Joe Darcy wrote:
>> Hello,
>>
>> The time approaches to being JDK 15! Please review the general 
>> langtools API and spec updates for this:
>>
>>     http://cr.openjdk.java.net/~darcy/8225361.5/
>>
>> The langtools portion includes two bugs with corresponding CSRs that 
>> also need review:
>>
>>     JDK-8235497: Add SourceVersion.RELEASE_15
>>     CSR: https://bugs.openjdk.java.net/browse/JDK-8235498
>>
>>     JDK-8235528: Add source 15 and target 15 to javac
>>     CSR: https://bugs.openjdk.java.net/browse/JDK-8235529
>>
>> It might be time to retire the notion of profiles for new releases, 
>> but that can be decided another day.
>>
>> Thanks,
>>
>> -Joe
>>