Builds fail due to use of preview features & removed arguments

[Maurizio Cimadamore]

On 20/12/2019 00:22, Ty Young wrote:
>
> On 12/19/19 6:12 PM, Maurizio Cimadamore wrote:
>>
>> On 20/12/2019 00:02, Ty Young wrote:
>>>
>>> On 12/19/19 5:44 PM, Maurizio Cimadamore wrote:
>>>>
>>>> On 19/12/2019 23:30, David Holmes wrote:
>>>>> I think this is more an issue for the language and compiler folk 
>>>>> on compiler-dev. I'm not clear on all the rules around use of 
>>>>> preview features but it seems to me that if we are using them 
>>>>> internally and that generates warnings then we should be 
>>>>> suppressing those warnings (@supressedWarning) at those call 
>>>>> sites. Though I don't know whether you can suppress a warning for 
>>>>> an import statement?? 
>>>>
>>>> We had an issue 3-4 weeks ago with preview warnings being issues in 
>>>> import. That issue was fixed and integrated with the big record push:
>>>>
>>>> http://hg.openjdk.java.net/jdk/jdk/rev/8e76f81d057a?revcount=20#l110.18 
>>>>
>>>>
>>>> In fact, I do not see any warning being triggered in my build.
>>>>
>>>> Ty mentioned that he's building from bits obtained from GitHub - so 
>>>> at this point I wonder what's the 'tip' of the jdk/jdk repository 
>>>> you are trying to build?
>>>
>>>
>>> Github link: https://github.com/openjdk/jdk.
>>
>> That repo looks fresh - are you sure your local HEAD matches the one 
>> you see in GitHub?
>
>
> git diff @{upstream} shows nothing different.

Ok - but what is your HEAD? At which commit is your local repo?

https://stackoverflow.com/questions/1967967/git-command-to-display-head-commit-id

Maurizio

>
>
>>
>> Maurizio
>>
>>>
>>>
>>> I didn't realize it, but it looks like y'all are already working on 
>>> 15. Changes made to 14 are pushed to 15 anyway so it doesn't matter, 
>>> right?
>>>
>>>
>>>>
>>>> Maurizio
>>>>