RFR [15] 8236435: Fix typos in javac area

[Jonathan Gibbons]

Pavel,

Thanks for looking at this. It was worth reading if only for the 
occasional amusement at some of the typos, and occasional guilt at 
recognizing some that I probably made. Here are some notes; none need a 
followup webrev.

I've reviewed all the individual changes, but since neither of us work 
routinely on all the javac source code, I would recommend also getting 
buy-in from an active javac developer that a widespread update like this 
is acceptable.

-- Jon


In 
src/jdk.compiler/share/classes/com/sun/tools/javac/comp/ArgumentAttr.java,
you missed a typo ;-)  "influences" should be "influenced"

In Pretty.java, the guideline is to avoid use of XXX and use something 
like XYZ instead.

- /** Exception to propogate IOException through visitXXX methods */
+ /** Exception to propagate IOException through visitXXX methods */

In sjavac Source.java, "lets" should be "let's"

- // Oups, the source is already added, could be ok, could be not, lets 
check.
+ // Oops, the source is already added, could be ok, could be not, lets 
check.


-- Jon


On 12/20/19 7:44 AM, Pavel Rappo wrote:
> Hello,
>
> Please review the following change for https://bugs.openjdk.java.net/browse/JDK-8236435:
>
>      http://cr.openjdk.java.net/~prappo/8236435/webrev.00/
>
> I've been reading up on the javadoc code and comments. At one point, jumping
> through the links, I reached the javax.tools.DocumentationTool and
> com.sun.tools.javac.util.ClientCodeException, which reside in java.compiler and
> jdk.compiler respectively. I found a couple of typos there and fixed them.
>
> One thing led to another and half an hour later I found myself compulsively
> checking the full javac code base for typos and spelling. Sigh.
>
> Long story short, I just went ahead and fixed as many issues as I could in one
> sitting. There was a lot.
>
> On the bright side, this patch doesn't involve any code changes (except for
> spelling in internal variables and methods' parameters), addresses aesthetic
> issues, readability, helps with searches and assists IDEs to pick up usages
> more reliably when refactoring (e.g. renaming).
>
> The initial concern with DocumentationTool turned out to be more subtle and I
> decided not to include it in this patch. It is definitely not just a typo and
> might require a CSR.
>
> Please review at your convenience. Hopefully, if there are false positives,
> you'll catch them.
>
> I suggest reviewing this change using a diff tool with a character-level
> resolution. That is, a tool capable of highlighting mismatching characters in
> lines that differ.
>
> All test/langtools tests pass. Copyright years will be fixed before the push.
>
> Thanks,
> -Pavel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20191220/ed613ce6/attachment-0001.htm>