RFR: JDK-8217381: Inconvenient errors reported when annotation processor generates source file and errors in the same round

Jonathan Gibbons jonathan.gibbons at oracle.com
Tue Feb 12 01:01:58 UTC 2019


Functionally OK, just minor nits

The rename in JCDiagnostic is OK, but the comment is a little obscure 
and could be clarified.

In Log.java, the name `acceptor` is a little clunky. That being said, 
it's in the dictionary, although the alternative spelling, accepter, 
looks better.

No need to re-review.

-- Jon

On 01/22/2019 05:43 AM, Jan Lahoda wrote:
> Hi,
>
> When an annotation processor generates a source and an error in the 
> same round, javac (may) print errors saying it cannot find the types 
> from the generated source.
>
> The proposal here is to improve the errors by deferring recoverable 
> error until the newly generated source is analyzed.
>
> JBS: https://bugs.openjdk.java.net/browse/JDK-8217381
> Webrev: http://cr.openjdk.java.net/~jlahoda/8217381/webrev.00/
>
> How does this look?
>
> Thanks,
>     Jan



More information about the compiler-dev mailing list