RFR: 8201544: Improve javac command line parsing and error reporting

Jonathan Gibbons jonathan.gibbons at oracle.com
Wed Feb 13 16:42:52 UTC 2019


In Option.java

765: Add a space between "}" and "catch".

766-768: I would remove the comment. It's not necessary, and doesn't add 
anything that isn't present via the metadata.  If you keep the comment, 
"windows" should be capitalized. "For ex" should be spelt in full, "For 
example".   But better to just remove the comment. The code stands for 
itself.

-- Jon

On 2/12/19 2:17 AM, srinivas.dama at oracle.com wrote:
> Hi,
>
> Please review http://cr.openjdk.java.net/~sdama/8201544/webrev.02/
>
> for https://bugs.openjdk.java.net/browse/JDK-8201544.
>
> This issue is specific to windows.
>
> Currently when * character is present in filename passed through API 
> call, javac throws weird exception message. With the fix, it is now 
> modified to throw an error instead of exception.
>
> Regards,
>
> Srinivas
>
>


More information about the compiler-dev mailing list