JDK 12 RFR of JDK-8219254: Update explicit uses of latest source/target in langtools tests to a property

[Joe Darcy]

Hello,

Re-revised webrev:

     http://cr.openjdk.java.net/~darcy/8219254.3/

This one leaves out the update to bump the jtreg used in 
make/conf/jib-profiles.js since that bump was recently pushed under 
another bug id. Also, the .3 version of webrev includes changes from Jon 
to address JDK-8219256: "Update javac diags tests to use properties."

I'll list both 8219254 and 8219256 in the changeset comment.

Thanks,

-Joe

On 2/20/2019 1:09 AM, Jan Lahoda wrote:
> Hi Joe,
>
> Looks good to me.
>
> Thanks!
>
> Jan
>
> On 19.2.2019 21:18, Joe Darcy wrote:
>> Hi Jon,
>>
>> Revised webrev:
>>
>>      http://cr.openjdk.java.net/~darcy/8219254.1/
>>
>> The ${jdk.version} idiom is still used for the @compile lines, which
>> cover most of the file updates.
>>
>> Thanks,
>>
>> -Joe
>>
>> On 2/19/2019 11:51 AM, Jonathan Gibbons wrote:
>>> Joe,
>>>
>>> I agree that seems preferable when it is reasonable to do so.
>>>
>>> You may still need the ${jdk.version} on the command line when using
>>> jtreg @compile.
>>>
>>> We will still need to update the diags/examples mechanisms.
>>>
>>> -- Jon
>>>
>>>
>>> On 02/19/2019 11:28 AM, Joe Darcy wrote:
>>>> Hi Jon,
>>>>
>>>> As a general note, it occurred to me that when the current release
>>>> number is referred to inside the source of a test, rather than
>>>> passing it through the command line, it can instead be gotten
>>>> programmatically using code like:
>>>>
>>>>     Integer.toString(Runtime.version().feature())
>>>>
>>>> The start of JDK 12 updates included changes like this for the
>>>> libraries tests.
>>>>
>>>> If you agree this is preferable, I can revise the webrev to use this
>>>> technique where appropriate in the langtools tests.
>>>>
>>>> Thanks,
>>>>
>>>> -Joe
>>>>
>>>> On 2/19/2019 10:40 AM, Jonathan Gibbons wrote:
>>>>>
>>>>>
>>>>> On 02/19/2019 10:23 AM, Joe Darcy wrote:
>>>>>>
>>>>>> Besides the future work files under diags/examples, after the
>>>>>> changes in the webrev, the remaining uses of "-source 13" are in
>>>>>>
>>>>>>     ./tools/javac/expswitch/ExpSwitchNestingTest.java
>>>>>
>>>>> Because this is a singleton file, it might be easiest to convert it
>>>>> to a "normal" jtreg test -- still using TestNG of course -- by
>>>>> removing the TEST.properties file, and using the standard test
>>>>> description tags, ending with `@run testng ...` to run the test.
>>>>>
>>>>> -- Jon
>>>