JDK 12 RFR of JDK-8219254: Update explicit uses of latest source/target in langtools tests to a property

[Jonathan Gibbons]

OK, I now better understand the weirdness of that test. Review approved.

-- Jon

On 2/21/19 9:38 AM, Joe Darcy wrote:
>
> Hi Jon,
>
> On 2/21/2019 9:30 AM, Jonathan Gibbons wrote:
>>
>> Mostly OK, but I think you've nullified/broken the test
>>
>> http://cr.openjdk.java.net/~darcy/8219254.3/test/langtools/tools/javac/6330997/T6330997.java.sdiff.html
>>
>> The test specifically comments:
>>
>>    27  * @summary javac should accept class files with major version of the next release
>>
>> And you've changed that behavior.
>>
> As briefly noted earlier in the review thread, when I looked at 
> T6330997.java more closely, it doesn't actually need the 
> -source/-target values being set. The class files for minimal source 
> files are written out and then modified to bump the version number. So 
> all that is needed is that the files are compiled under the current 
> target, which can be implemented implicitly without -source/-target 
> options.
>
> (I and others have updated this file without much consideration for 
> the last few version updates; better to leave it be if possible!)
>
> Thanks,
>
> -Joe
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20190221/433f70f2/attachment.html>