JDK 12 RFR of JDK-8216322 : Missing since information in deprecation of constructor visitors

Joe Darcy joe.darcy at oracle.com
Tue Jan 8 07:26:39 UTC 2019


Hello,

When the JDK 7-era constructors were deprecated earlier in JDK 12 
(JDK-8173606), the "since" deprecation information should have been 
included. Please review the changes to add the since information after 
the fact along with its CSR:

     http://cr.openjdk.java.net/~darcy/8216322.0/
     http://bugs.openjdk.java.net/browse/JDK-8216351

Patch below.

Files updating using sed.

Thanks,

-Joe

--- 
old/src/java.compiler/share/classes/javax/lang/model/util/AbstractAnnotationValueVisitor7.java 
2019-01-07 23:13:31.340000000 -0800
+++ 
new/src/java.compiler/share/classes/javax/lang/model/util/AbstractAnnotationValueVisitor7.java 
2019-01-07 23:13:31.140000000 -0800
@@ -68,7 +68,7 @@
       * @deprecated Release 7 is obsolete; update to a visitor for a newer
       * release level.
       */
-    @Deprecated
+    @Deprecated(since="12")
      protected AbstractAnnotationValueVisitor7() {
          super(); // Superclass constructor deprecated too
      }
--- 
old/src/java.compiler/share/classes/javax/lang/model/util/AbstractElementVisitor7.java 
2019-01-07 23:13:31.780000000 -0800
+++ 
new/src/java.compiler/share/classes/javax/lang/model/util/AbstractElementVisitor7.java 
2019-01-07 23:13:31.584000000 -0800
@@ -71,7 +71,7 @@
       * @deprecated Release 7 is obsolete; update to a visitor for a newer
       * release level.
       */
-    @Deprecated
+    @Deprecated(since="12")
      protected AbstractElementVisitor7(){
          super(); // Superclass constructor deprecated too
      }
--- 
old/src/java.compiler/share/classes/javax/lang/model/util/AbstractTypeVisitor7.java 
2019-01-07 23:13:32.196000000 -0800
+++ 
new/src/java.compiler/share/classes/javax/lang/model/util/AbstractTypeVisitor7.java 
2019-01-07 23:13:32.000000000 -0800
@@ -71,7 +71,7 @@
       * @deprecated Release 7 is obsolete; update to a visitor for a newer
       * release level.
       */
-    @Deprecated
+    @Deprecated(since="12")
      protected AbstractTypeVisitor7() {
          super();  // Superclass constructor deprecated too
      }
--- 
old/src/java.compiler/share/classes/javax/lang/model/util/ElementKindVisitor7.java 
2019-01-07 23:13:32.620000000 -0800
+++ 
new/src/java.compiler/share/classes/javax/lang/model/util/ElementKindVisitor7.java 
2019-01-07 23:13:32.428000000 -0800
@@ -85,7 +85,7 @@
       * @deprecated Release 7 is obsolete; update to a visitor for a newer
       * release level.
       */
-    @Deprecated
+    @Deprecated(since="12")
      protected ElementKindVisitor7() {
          super(null); // Superclass constructor deprecated too
      }
@@ -99,7 +99,7 @@
       * @deprecated Release 7 is obsolete; update to a visitor for a newer
       * release level.
       */
-    @Deprecated
+    @Deprecated(since="12")
      protected ElementKindVisitor7(R defaultValue) {
          super(defaultValue); // Superclass constructor deprecated too
      }
--- 
old/src/java.compiler/share/classes/javax/lang/model/util/ElementScanner7.java 
2019-01-07 23:13:33.028000000 -0800
+++ 
new/src/java.compiler/share/classes/javax/lang/model/util/ElementScanner7.java 
2019-01-07 23:13:32.836000000 -0800
@@ -98,7 +98,7 @@
       * @deprecated Release 7 is obsolete; update to a visitor for a newer
       * release level.
       */
-    @Deprecated
+    @Deprecated(since="12")
      protected ElementScanner7(){
          super(null); // Superclass constructor deprecated too
      }
@@ -112,7 +112,7 @@
       * @deprecated Release 7 is obsolete; update to a visitor for a newer
       * release level.
       */
-    @Deprecated
+    @Deprecated(since="12")
      protected ElementScanner7(R defaultValue){
          super(defaultValue); // Superclass constructor deprecated too
      }
--- 
old/src/java.compiler/share/classes/javax/lang/model/util/SimpleAnnotationValueVisitor7.java 
2019-01-07 23:13:33.432000000 -0800
+++ 
new/src/java.compiler/share/classes/javax/lang/model/util/SimpleAnnotationValueVisitor7.java 
2019-01-07 23:13:33.240000000 -0800
@@ -75,7 +75,7 @@
       * @deprecated Release 7 is obsolete; update to a visitor for a newer
       * release level.
       */
-    @Deprecated
+    @Deprecated(since="12")
      protected SimpleAnnotationValueVisitor7() {
          super(null); // Superclass constructor deprecated too
      }
@@ -89,7 +89,7 @@
       * @deprecated Release 7 is obsolete; update to a visitor for a newer
       * release level.
       */
-    @Deprecated
+    @Deprecated(since="12")
      protected SimpleAnnotationValueVisitor7(R defaultValue) {
          super(defaultValue); // Superclass constructor deprecated too
      }
--- 
old/src/java.compiler/share/classes/javax/lang/model/util/SimpleElementVisitor7.java 
2019-01-07 23:13:33.840000000 -0800
+++ 
new/src/java.compiler/share/classes/javax/lang/model/util/SimpleElementVisitor7.java 
2019-01-07 23:13:33.644000000 -0800
@@ -81,7 +81,7 @@
       * @deprecated Release 7 is obsolete; update to a visitor for a newer
       * release level.
       */
-    @Deprecated
+    @Deprecated(since="12")
      protected SimpleElementVisitor7(){
          super(null); // Superclass constructor deprecated too
      }
@@ -95,7 +95,7 @@
       * @deprecated Release 7 is obsolete; update to a visitor for a newer
       * release level.
       */
-    @Deprecated
+    @Deprecated(since="12")
      protected SimpleElementVisitor7(R defaultValue){
          super(defaultValue); // Superclass constructor deprecated too
      }
--- 
old/src/java.compiler/share/classes/javax/lang/model/util/SimpleTypeVisitor7.java 
2019-01-07 23:13:34.252000000 -0800
+++ 
new/src/java.compiler/share/classes/javax/lang/model/util/SimpleTypeVisitor7.java 
2019-01-07 23:13:34.060000000 -0800
@@ -81,7 +81,7 @@
       * @deprecated Release 7 is obsolete; update to a visitor for a newer
       * release level.
       */
-    @Deprecated
+    @Deprecated(since="12")
      protected SimpleTypeVisitor7(){
          super(null); // Superclass constructor deprecated too
      }
@@ -95,7 +95,7 @@
       * @deprecated Release 7 is obsolete; update to a visitor for a newer
       * release level.
       */
-    @Deprecated
+    @Deprecated(since="12")
      protected SimpleTypeVisitor7(R defaultValue){
          super(defaultValue); // Superclass constructor deprecated too
      }
--- 
old/src/java.compiler/share/classes/javax/lang/model/util/TypeKindVisitor7.java 
2019-01-07 23:13:34.668000000 -0800
+++ 
new/src/java.compiler/share/classes/javax/lang/model/util/TypeKindVisitor7.java 
2019-01-07 23:13:34.476000000 -0800
@@ -82,7 +82,7 @@
       * @deprecated Release 7 is obsolete; update to a visitor for a newer
       * release level.
       */
-    @Deprecated
+    @Deprecated(since="12")
      protected TypeKindVisitor7() {
          super(null); // Superclass constructor deprecated too
      }
@@ -96,7 +96,7 @@
       * @deprecated Release 7 is obsolete; update to a visitor for a newer
       * release level.
       */
-    @Deprecated
+    @Deprecated(since="12")
      protected TypeKindVisitor7(R defaultValue) {
          super(defaultValue); // Superclass constructor deprecated too
      }



More information about the compiler-dev mailing list