RFR: 8216403: Allocate fewer EnumSets in JavacFileManager#list

Claes Redestad claes.redestad at oracle.com
Wed Jan 9 09:48:12 UTC 2019


not really a langtools reviewer, but I generally avoid using raw
static EnumSets due their mutable nature (not saying there's a bug
here - just that we should consider all possible futures and treat them

Set.of() / Set.of(FOLLOW_LINKS) is a compact, performant and safer 



On 2019-01-09 02:44, Liam Miller-Cushon wrote:
> Hi,
> Please consider this trivial performance improvement, which moves a 
> couple of allocations out of JavacFileManager#list.
> bug: https://bugs.openjdk.java.net/browse/JDK-8216403
> webrev: http://cr.openjdk.java.net/~cushon/8216403/webrev.00/
> Thanks,
> Liam

More information about the compiler-dev mailing list