JDK 13 RFR of JDK-8208371: Provided supported mechanims to create a ModuleElement for an unnamed module
Joseph D. Darcy
joe.darcy at oracle.com
Thu Jan 10 22:51:07 UTC 2019
Hello,
Please review the change and CSR to implement
JDK-8208371: Provided supported mechanims to create a ModuleElement
for an unnamed module
webrev: http://cr.openjdk.java.net/~darcy/8208371.0/
CSR: https://bugs.openjdk.java.net/browse/JDK-8216527
Patch below.
Thanks,
-Joe
---
old/src/java.compiler/share/classes/javax/lang/model/util/Elements.java
2019-01-10 14:40:14.594256000 -0800
+++
new/src/java.compiler/share/classes/javax/lang/model/util/Elements.java
2019-01-10 14:40:14.342130000 -0800
@@ -189,7 +189,7 @@
/**
* Returns a module element given its fully qualified name.
*
- * If the named module cannot be found, {@code null} is
+ * If the requested module cannot be found, {@code null} is
* returned. One situation where a module cannot be found is if
* the environment does not include modules, such as an annotation
* processing environment configured for a {@linkplain
@@ -199,7 +199,7 @@
* @implSpec The default implementation of this method returns
* {@code null}.
*
- * @param name the name
+ * @param name the name, or an empty string for an unnamed module
* @return the named module element, or {@code null} if it cannot
be found
* @see #getAllModuleElements
* @since 9
---
old/test/langtools/tools/javac/processing/model/element/TestModuleElementNames.java
2019-01-10 14:40:15.174546001 -0800
+++
new/test/langtools/tools/javac/processing/model/element/TestModuleElementNames.java
2019-01-10 14:40:14.918418000 -0800
@@ -23,7 +23,7 @@
/*
* @test
- * @bug 8163989
+ * @bug 8163989 8208371
* @summary Test basic workings of naming methods on ModuleElement
* @library /tools/javac/lib
* @modules java.compiler
More information about the compiler-dev
mailing list