RFR: JDK-8216529: in case of a crash, javac should print out the parameters passed to it

[Liam Miller-Cushon]

Hi Vicente,

This looks useful.

Did you consider printing the args to stderr instead of writing them to a
file, maybe as part of msg.bug? If I'm reading the patch correctly it
currently uses a file `javac.<date>.args` in the directory javac is running
from, which users won't necessarily know about to include in crash reports,
and which won't succeed if javac doesn't have permissions to create files
in the working directory.

On Mon, Jan 14, 2019 at 10:51 AM Vicente Romero <vicente.romero at oracle.com>
wrote:

> Please review the fix for enhancement [1] at [2]. The idea of this
> enhancement is to print out to a file the arguments passed to javac is
> there is a fatal error or if a hidden option is passed to the compiler.
> This could be very helpful to reproduce some bugs reported by users.
>
> Thanks,
> Vicente
>
> PS, thanks to Jon for offline feedback an suggestions
>
> [1] https://bugs.openjdk.java.net/browse/JDK-8216529
> [2] http://cr.openjdk.java.net/~vromero/8216529/webrev.00/
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20190114/3d555157/attachment.html>