RFR [XS] : 8227247: tools/sjavac/IdleShutdown.java fails with AssertionError: Error too big on windows

[Thomas Stüfe]

Hi Matthias,

seems reasonable. Change looks good.

Cheers, Thomas



On Fri, Jul 5, 2019 at 5:58 PM Baesken, Matthias <matthias.baesken at sap.com>
wrote:

> Hello,
>
>    please review this small change to  tools/sjavac/IdleShutdown.java  .
>
> It  allows higher timeout differences and gives a better error output .
>
>
>
>
>
> On Windows (especially on slower virtualized machines) the langtools test
> tools/sjavac/IdleShutdown.java shows sporadic failures.
> The error we see is :
> IdleShutdown.java: java.lang.AssertionError: Error too big
>
> Reason is that the "timeout error" is larger than the allowed error of 300
> ms    ( 3000 ms *0.1)  :
>
>         if (error > TIMEOUT_MS * .1)
>             throw new AssertionError("Error too big");
>
> We see sometimes errors in the range of 300-900 ms .
> For example :
>
> After 16166 ms: Timeout error: 609 ms
>
> Idea is to increase the allowed timeout error to make the test more stable.
>
>
>
>
>
>
>
> Bug/webrev :
>
>
>
> https://bugs.openjdk.java.net/browse/JDK-8227247
>
>
>
> http://cr.openjdk.java.net/~mbaesken/webrevs/8227247.0/webrev/
>
>
>
>
>
> Thanks, Matthias
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20190705/1c0147bb/attachment.html>