RFR [XS] : 8227247: tools/sjavac/IdleShutdown.java fails with AssertionError: Error too big on windows

Baesken, Matthias matthias.baesken at sap.com
Thu Jul 18 06:35:43 UTC 2019

Hi Jon + Thomas ,  thanks for the reviews !

Best regards, Matthias

From: Jonathan Gibbons <jonathan.gibbons at oracle.com>
Sent: Mittwoch, 17. Juli 2019 17:11
To: Baesken, Matthias <matthias.baesken at sap.com>; compiler-dev at openjdk.java.net
Cc: Zeller, Arno <arno.zeller at sap.com>
Subject: Re: RFR [XS] : 8227247: tools/sjavac/IdleShutdown.java fails with AssertionError: Error too big on windows


Looks better,

-- Jon
On 7/10/19 2:40 AM, Baesken, Matthias wrote:

Hi Jon,   I switched to  the  proposed   test.timeout.factor   property :


Best regards, Matthias


Generally, the typical way to handle timeouts on slow machines is to use
the jtreg "timeout factor" mechanism, which is a multiplicative factor
that can be set from the command line.  This allows timeouts to be
increased on slow machines without unduly increasing timeouts for all

Within the test, the value is available in the `test.timeout.factor`
system property.


-- Jon

On Fri, Jul 5, 2019 at 5:58 PM Baesken, Matthias <matthias.baesken at sap.com<mailto:matthias.baesken at sap.com>> wrote:
   please review this small change to  tools/sjavac/IdleShutdown.java  .
It  allows higher timeout differences and gives a better error output .

On Windows (especially on slower virtualized machines) the langtools test tools/sjavac/IdleShutdown.java shows sporadic failures.
The error we see is :
IdleShutdown.java: java.lang.AssertionError: Error too big

Reason is that the "timeout error" is larger than the allowed error of 300 ms    ( 3000 ms *0.1)  :

        if (error > TIMEOUT_MS * .1)
            throw new AssertionError("Error too big");

We see sometimes errors in the range of 300-900 ms .
For example :

After 16166 ms: Timeout error: 609 ms

Idea is to increase the allowed timeout error to make the test more stable.

Bug/webrev :



Thanks, Matthias
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20190718/24ba7ad1/attachment-0001.html>

More information about the compiler-dev mailing list