RFR(trivial): 8227512: [TESTBUG] Fix JTReg javac test failures with Graal

Pengfei Li (Arm Technology China) Pengfei.Li at arm.com
Thu Jul 18 06:51:35 UTC 2019

Hi Alan,

> I see this has been pushed but it looks like it is missing `@modules
> jdk.internal.vm.compiler` as the test now requires this module to be in the
> run-time image under test. As the test is not interesting when testing with the
> Graal compiler then maybe an alternative is to add
> `@requires !vm.graal.enabled` so that the test is not selected when
> exercising Graal - we've done this in a few other tests that run with `--limit-
> modules`.

Thanks for reply. I've used this alternative approach before when I tried to clean up other false failures in Graal jtreg (see http://hg.openjdk.java.net/jdk/jdk/rev/206afa6372ae). This time I choose to add the missing module because I thought the javac test would be interesting when Graal is used since javac is also written in Java. This change is already pushed, but it's fine to me if you would like to submit another patch to disable this two cases with Graal.


More information about the compiler-dev mailing list