RFR: JDK-8216261: Javap ignores default modifier on interfaces

[Vicente Romero]

OK I will fix that before pushing,

Thanks for the review,
Vicente

On 6/5/19 9:46 AM, Jonathan Gibbons wrote:
>
> That's OK, but it might be slightly better to do:
>
>    71         String output = new JavapTask(tb)
>    72                 .options("-p", testClassesPath.resolve(this.getClass().getSimpleName() + "$SimpleInterface.class").toString())
>    73                 .run()
> +                    .writeAll()
>    74                 .getOutput(Task.OutputKind.DIRECT);
> On 6/5/19 6:43 AM, Vicente Romero wrote:
>> Hi Jon,
>>
>> Thanks for your comments, what about [1]?
>>
>> Vicente
>>
>> [1] http://cr.openjdk.java.net/~vromero/8216261/webrev.01/
>>
>> On 6/4/19 7:24 PM, Jonathan Gibbons wrote:
>>>
>>>
>>> On 06/04/2019 04:08 PM, Vicente Romero wrote:
>>>> Please review fix for [1] at [2]. This is an enhancement request 
>>>> asking to make javap show if a method has the default modifier or not.
>>>>
>>>> Thanks,
>>>> Vicente
>>>>
>>>> [1] https://bugs.openjdk.java.net/browse/JDK-8216261
>>>> [2] http://cr.openjdk.java.net/~vromero/8216261/webrev.00/
>>>
>>> The main source change looks OK,
>>>
>>> The test could be improved:
>>>
>>> 1. If the test fails, nothing is printed to show what went wrong 
>>> because a basic assertion of "incorrect output". What was the 
>>> incorrect output?  It should *always* be the case for *all* tests 
>>> that a test should try and give as much output as is reasonable when 
>>> the test fails, to give the person analyzing the test failure as 
>>> much as possible.
>>>
>>> 2. (Less important)  Personally, I think it is bad style to 
>>> construct pathnames with string bashing. (I've been burnt too 
>>> often!)  Generally it is better to use the File or Path API to 
>>> construct filenames, and then use .toString().
>>>
>>> -- Jon
>>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20190605/8a3dd5f0/attachment-0001.html>