RFR: JDK-8223942: Missing methods in ClientCodeWrapper$WrappedJavaFileManager

Jonathan Gibbons jonathan.gibbons at oracle.com
Wed Jun 5 18:49:46 UTC 2019

Mostly excellent, and very clever, with one tiny nit:

   65         Method[] declaredMethods = subClass.getMethods();

The name "declaredMethods" is confusing, because it might be thought to 
be related to subClass.getDeclaredMethods(), which it is not.

I suggest a rename to either "allMethods" or just "methods".

-- Jon

On 06/05/2019 11:39 AM, Vicente Romero wrote:
> Please review fix for [1] at [2]. Some methods in 
> javax.tools.JavaFileManager and javax.tools.StandardJavaFileManager 
> were not overriden by wrapper classes provided at 
> com.sun.tools.javac.api.ClientCodeWrapper. The fix is adding the 
> missing methods plus providing a test to future check issues for the 
> corresponding wrapping classes in the future. The test doesn't cover 
> other wrapping classes. That could be achieve as an additional RFE if 
> needed,
> Thanks,
> Vicente
> [1] https://bugs.openjdk.java.net/browse/JDK-8223942
> [2] http://cr.openjdk.java.net/~vromero/8223942/webrev.00/

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20190605/d1abeafa/attachment.html>

More information about the compiler-dev mailing list