RFR: 8225644: [TESTBUG] langtools/tools/javac/generics/inference/8058199/T8058199.java fails with -Xcomp

Joe Darcy joe.darcy at oracle.com
Thu Jun 13 01:14:20 UTC 2019


Hi Jie,

To a first approximation, javac's output should predictably rely in its 
inputs. In other words, the output of javac, and by extension the 
success or failure of one its regression tests, should be independent of 
running under a particular HotSpot mode/configuration.

If test success/failure is dependent on a mode or configuration, I would 
suggest eliminating a VM issue as a cause before looking to update the test.

HTH,

-Joe

On 6/11/2019 11:14 PM, Jie Fu wrote:
> Hi Joe,
>
> Thanks for your review.
> Do you mean the JIT shouldn't dump the signature like 
> "[Ljava/lang/String;"?
>
> I'd like to do more investigation.
> Thanks.
>
> Best regards,
> Jie
>
> On 2019/6/12 下午2:01, Joe Darcy wrote:
>> Hello,
>>
>> If the javac test is only failing under -Xcomp, a reasonable avenue 
>> to investigate is that -Xcomp is misbehaving rather than the test code.
>>
>> Cheers,
>>
>> -Joe
>>
>> On 6/11/2019 10:56 PM, Jie Fu wrote:
>>> Hi all,
>>>
>>> JBS:    https://bugs.openjdk.java.net/browse/JDK-8225644
>>> Webrev: http://cr.openjdk.java.net/~jiefu/8225644/webrev.00/
>>>
>>> Reason: with -Xcomp, the signature was dumped as 
>>> "[Ljava/lang/String;" rather than "[Ljava.lang.String;".
>>> Fix: It might be better to replace '/' with '.' before matching.
>>>
>>> Could you please review it?
>>>
>>> Thanks a lot.
>>> Best regards,
>>> Jie
>>>
>>>
>


More information about the compiler-dev mailing list