JDK 14 RFR of JDK-8222369: ExecutableElement.getReceiverType returns null instead of NOTYPE

[Jonathan Gibbons]

OK.

I think the method to fix ElementStructureTest is clever, as a way of 
minimally changing an existing test to test the change in behavior, but 
now that we have verified the change in behavior, it might be nice to 
simplify ElementStructureTest to remove that part of the change. That 
could be done later, if you want, but if you leave ElementStructureTest 
functionally as-is, I suggest you add a comment to the 
typeMirorTranslate method to explain what might seem to be strange 
behavior with anyone not familiar with this part of its history.

-- Jon


On 06/13/2019 04:06 PM, Joseph D. Darcy wrote:
> Hello,
>
> Now that there is a line of development for JDK 14 separate from JDK 
> 13, please review the fix and CSR for
>
>     JDK-8222369: ExecutableElement.getReceiverType returns null 
> instead of NOTYPE
>     webrev: http://cr.openjdk.java.net/~darcy/8222369.1/
>     CSR: https://bugs.openjdk.java.net/browse/JDK-8225755
>
> For ElementStructureTest.java, I mapped back the results of 
> getReceiverType to null to verify no other behavior of the method was 
> unintentionally changed. The hashes used for comparison in the test 
> could be updated instead.
>
> Since there is the possibility users of the method might have worked 
> around its old behavior, getting the fix into build 01 of JDK 14 
> maximizes the time to flush out any behavioral incompatibilities.
>
> Thanks,
>
> -Joe
>
>
> On 6/6/2019 2:52 PM, Joe Darcy wrote:
>> Hello,
>>
>> Please review the fix for
>>
>>     JDK-8222369: ExecutableElement.getReceiverType returns null 
>> instead of NOTYPE
>>     http://cr.openjdk.java.net/~darcy/8222369.0/
>>
>> In the javac implementation, the getReceiverType method is pulled up 
>> to the root of the hierarchy and is defined to return null.
>>
>> The hashing in tools/javac/ElementStructureTest will also need to be 
>> adjusted when this fix goes in since that test does factor the result 
>> of getReceiver type into its hash.
>>
>> Thanks,
>>
>> -Joe
>>
>