RFR: 8220633: Optimize CacheFSInfo

Jonathan Gibbons jonathan.gibbons at oracle.com
Thu Mar 14 00:59:25 UTC 2019


OK.

I could go either way on getJarClassPath.  The initial version in 
webrev.00 was definitely shorter.

-- Jon


On 03/13/2019 05:39 PM, Liam Miller-Cushon wrote:
> On Wed, Mar 13, 2019 at 5:12 PM Jonathan Gibbons 
> <jonathan.gibbons at oracle.com <mailto:jonathan.gibbons at oracle.com>> wrote:
>
>     Please don't reformat the scary comment ;-)  You'll frighten away
>     any scripts
>     that might check for the comment.
>
> Thanks--the reformatting of unchanged lines was accidental, I reverted 
> those parts.
>
>     Is there a reason you don't use computeIfAbsent in getJarClassPath?
>
> I switched to use computeIfAbsent there too.
>
> It does requires wrapping/unwrapping the IOException, but I think it's 
> probably still a better choice. Mostly I was focused on the other 
> other methods.
>
> Here's the updated webrev: 
> http://cr.openjdk.java.net/~cushon/8220633/webrev.01/ 
> <http://cr.openjdk.java.net/%7Ecushon/8220633/webrev.01/>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20190313/e0492921/attachment.html>


More information about the compiler-dev mailing list