RFR: 8220687: Change signature of StandardJavaFileManager.getJavaFileObjectsFromPaths

[Joseph D. Darcy]

Hello Liam,

On 3/14/2019 6:19 PM, Liam Miller-Cushon wrote:
> Hi,
>
> This change adds a getJavaFileObjectsFromPaths(Collection<Path>) 
> method, and deprecates the existing 
> getJavaFileObjectsFromPaths(Iterable<Path>). The motivation is the 
> same as JDK-8150111, which made a similar change to 
> setLocationFromPaths: methods that take Iterable<Path> are error-prone 
> since Path itself implements Iterable<Path>.
>
> I have two initial questions: do you think this is worthwhile, and if 
> so what's the correct process (should I file a CSR?).
>
> bug: https://bugs.openjdk.java.net/browse/JDK-8220687
> webrev: http://cr.openjdk.java.net/~cushon/8220687/webrev.00/ 
> <http://cr.openjdk.java.net/%7Ecushon/8220687/webrev.00/>
>

On the process question, if this change goes forward it will need a CSR 
since it is change to a Java SE API.

For an overview of the CSR process, see the CSR wiki 
(https://wiki.openjdk.java.net/display/csr/Main) and a recent 
presentation about the CSR given at the OCW 
(http://cr.openjdk.java.net/~darcy/Presentations/OCW/ocw-CSR-2019-02.pdf).

HTH,

-Joe