RFR 8221118: Avoid eagerly creating JCDiagnostic for CompletionFailures

Liam Miller-Cushon cushon at google.com
Wed Mar 27 20:05:16 UTC 2019


It still looks good to me, FWIW.

On Wed, Mar 27, 2019 at 10:47 AM Ron Shapiro <ronshapiro at google.com> wrote:

> I missed a few cases earlier - see this updated webrev:
> http://cr.openjdk.java.net/~ronsh/8221118/webrev.01/
>
> On Tue, Mar 26, 2019 at 4:10 PM Jonathan Gibbons <
> jonathan.gibbons at oracle.com> wrote:
>
>> Looks OK to me, especially the similarity to JDK-8215368
>>
>> -- Jon
>>
>> On 03/19/2019 03:37 PM, Ron Shapiro wrote:
>>
>> Hi,
>>
>> This is a small change that avoids eagerly creating JCDiagnostic for
>> CompletionFailures.
>>
>> webrev: http://cr.openjdk.java.net/~ronsh/8221118/webrev.00/
>> bug: https://bugs.openjdk.java.net/browse/JDK-8221118
>>
>> Thanks,
>> Ron
>>
>>
>>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20190327/6c690228/attachment.html>


More information about the compiler-dev mailing list