RFR 8221118: Avoid eagerly creating JCDiagnostic for CompletionFailures

[Ron Shapiro]

If your concern is performance of creating the () -> null supplier, that's
created only once in the ClassFinder constructor. I don't think it's worth
adding an overload + constant just for that.

On Thu, Mar 28, 2019 at 5:08 PM Maurizio Cimadamore <
maurizio.cimadamore at oracle.com> wrote:

>
> On 28/03/2019 13:43, Ron Shapiro wrote:
> > From what the code is currently doing, `() -> null` could be made into
> > just `null`. On my own, I didn't feel comfortable introducing that and
> > preferred to remain consistent, but if you think I should make the
> > change I defer to you.
>
> Maybe we could have an override that takes no 'supplier', and instead
> uses a predefined () -> null supplier defined somewhere, so that it
> doesn't get created all the time.
>
> Thanks for the additional data points.
>
> Maurizio
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20190328/be6d7725/attachment.html>