RFR: JDK-8222744: add support for generating method handles from a variable symbol

[Vicente Romero]

On 5/1/19 4:04 AM, Maurizio Cimadamore wrote:
> Looks good - an alternative would have been to use an anonymous inner 
> class creation in VarSymbol::asMethodHandle, but I don't feel strongly 
> either way, and I'll leave the decision to you.

Thanks for the review. I think I prefer the code this way as it is using 
the same approach as MethodSymbol::asHandle

Vicente

>
> Maurizio
>
> On 22/04/2019 22:16, Vicente Romero wrote:
>> Please review the fix for [1] at [2]. This is a small follow up after 
>> [3] which introduced a new internal constant pool API in javac. We 
>> realized that it was not possible to generate with the new API method 
>> handles with reference kinds:
>>
>>  * REF_getField
>>  * REF_putField
>>  * REF_getStatic
>>  * REF_putStatic
>>
>> This patch adds that feature,
>>
>> Thanks,
>> Vicente
>>
>> [1] https://bugs.openjdk.java.net/browse/JDK-8222744
>> [2] http://cr.openjdk.java.net/~vromero/8222744/
>> [3] https://bugs.openjdk.java.net/browse/JDK-8222289