RFR: JDK-8222949: add condy support to javac's pool API

[Vicente Romero]

On 5/8/19 5:37 AM, Maurizio Cimadamore wrote:
> Looks very good!

:) thanks

>
> One minor nit, unrelated to your patch, looking at the webrev I noted 
> that DynamicItem::store is doing 'assert false' - I think a better 
> idiom would be to use the Assert.error() facility, so that if this 
> failure is triggered an exception will be thrown no matter what.

right I will do that change before pushing the patch

>
> Thanks
> Maurizio

Thanks for the review,
Vicente

>
> On 08/05/2019 00:01, Vicente Romero wrote:
>> Please review the fix for [1] at [2]. This enhancement is related to 
>> [3] which introduced a new API for constant pool reading / writing in 
>> javac. The current patch adds condy support that was missing.
>>
>> Thanks,
>> Vicente
>>
>> [1] https://bugs.openjdk.java.net/browse/JDK-8222949
>> [2] http://cr.openjdk.java.net/~vromero/8222949/webrev.00/
>> [3] https://bugs.openjdk.java.net/browse/JDK-8222289