RFR: 8223553: Fix code constructs that do not compile with the Eclipse Java Compiler

[David Holmes]

Hi Christoph,

I'm very reluctant to see changes like this that the compiler folk have 
not determined are actually incorrect. That said ...

On 15/05/2019 7:03 am, Langer, Christoph wrote:
> Thanks Daniel.
> 
> Can anybody help reviewing the changes to:
> src/java.base/share/classes/java/lang/invoke/MethodHandles.java

The introduction of the intermediate local variable seems harmless 
(though why it should be necessary is another matter).

> src/java.base/share/classes/java/util/concurrent/ConcurrentSkipListMap.java

As you note this should be ok'd by jsr166 folk so I've cc'd Martin 
Buccholz. I dislike seeing a raw type introduced here though.

> and
> src/java.management/share/classes/java/lang/management/ManagementFactory.java ?

Introducing an unchecked cast seems very crude. I'd want the core-libs 
stream experts to comment on this.

Cheers,
David
----

> Thanks
> Christoph
> 
>> -----Original Message-----
>> From: Daniel Fuchs <daniel.fuchs at oracle.com>
>> Sent: Dienstag, 14. Mai 2019 18:04
>> To: Langer, Christoph <christoph.langer at sap.com>; core-libs-dev <core-libs-
>> dev at openjdk.java.net>; net-dev <net-dev at openjdk.java.net>
>> Cc: compiler-dev at openjdk.java.net
>> Subject: Re: RFR: 8223553: Fix code constructs that do not compile with the
>> Eclipse Java Compiler
>>
>> Hi Christoph,
>>
>> That looks much better, thanks!
>> (but still not commenting on the other changes ;-))
>>
>> best regards,
>>
>> -- daniel
>>
>> On 14/05/2019 13:57, Langer, Christoph wrote:
>>> Hi Daniel,
>>>
>>>>> unfortunately, your proposed solution does not work with javac. I get
>> this
>>>> in the build:
>>>>
>>>> Oh darn. I should have double checked.
>>>> Can we at least reduce the scope of the @SuppressedWarnings by
>>>> introducing a private method that just has the return call?
>>>
>>> Sure, what about this one:
>> http://cr.openjdk.java.net/~clanger/webrevs/8223553.2/ ?
>>>
>>> Thanks
>>> Christoph
>>>
>