RFR (CSR) - JDK-8223776 String::stripIndent (Preview)

Brent Christian brent.christian at oracle.com
Fri May 24 21:00:43 UTC 2019


In the description of the re-indentation algorithm, I think it's worth 
clarifying that the last line is always included.  So perhaps:

"3. The last line (i.e., the line with the text block closing delimiter) 
is included in the set of determining lines, even if it is blank. (The 
indentation of the closing delimiter should influence the indentation of 
the content as a whole -- a "significant trailing line" policy.)"

I think the corresponding portion of the JavaDoc is good.


On 5/24/19 5:17 AM, Jim Laskey wrote:
> Please do a CSR review of the new String::stripIndent instance method. This instance method is being introduced to support JEP-355: Text Blocks, by removing incidental indentation from the text block content. The algorithm used is defined in the JEP and also described in the JBS entry.
> Thank you.
> -- Jim
> csr: https://bugs.openjdk.java.net/browse/JDK-8223776 <https://bugs.openjdk.java.net/browse/JDK-8223776>
> webrev: http://cr.openjdk.java.net/~jlaskey/8223775/webrev-02 <http://cr.openjdk.java.net/~jlaskey/8223775/webrev-02>
> jbs: https://bugs.openjdk.java.net/browse/JDK-8223775 <https://bugs.openjdk.java.net/browse/JDK-8223775>
> jep: https://bugs.openjdk.java.net/browse/JDK-8222530 <https://bugs.openjdk.java.net/browse/JDK-8222530>

More information about the compiler-dev mailing list