RFR: JDK-8223305: Compiler support for Switch Expressions

[Maurizio Cimadamore]

Looks good. Just few comments/questions:

* I think the error keys in compiler.properties could use some renaming. 
e.g.

compiler.err.break.complex.value.no.switch.expression -> 
compiler.err.no.switch.expression
compiler.err.break.complex.value.no.switch.expression.qualify -> 
compiler.err.no.switch.expression.qualify

* what is the new Log.hasErrorOn - and why has Flow been changed to use it?

Thanks
Maurizio


It seems like a whitespace got remove here?

On 24/05/2019 15:48, Jan Lahoda wrote:
> Hi,
>
> I'd like to ask for a review of changes to update javac to follow the 
> current spec for switch expressions, in particular the break -> yield 
> change:
> http://cr.openjdk.java.net/~gbierman/jep354-jls-20190524.html
>
> Webrev:
> http://cr.openjdk.java.net/~jlahoda/8223303/webrev.00/
>
> JBS:
> https://bugs.openjdk.java.net/browse/JDK-8223305
>
> Feedback is welcome!
>
> Thanks,
>    Jan