RFR: 8224629: Unnecessary indirection in LambdaToMethod

Vicente Romero vicente.romero at oracle.com
Tue May 28 16:29:01 UTC 2019


I think that I prefer the flexibility that invoking the ::asHandle 
method brings. Suppose that a subclass wants to provide an 
implementation of the asHandle method that will return the non-obvious 
result. Not a high probability case but we have seen similar uses to the 
Symbol::baseSymbol method. I think I prefer to have options,

Vicente

On 5/22/19 8:50 PM, Alan Malloy wrote:
> Hello. Please review this patch to eliminate an unnecessary upcast and 
> method call in LambdaToMethod.
>
> bug: https://bugs.openjdk.java.net/browse/JDK-8224629
> webrev: http://cr.openjdk.java.net/~cushon/8224629/webrev.00/
>
> Testing: All of jtreg:test/langtools/tools/javac pass locally. No new 
> test added, as no behavior change is intended.
>
> Thanks,
>     Alan



More information about the compiler-dev mailing list