Fwd: Re: RFR: JEP 359-Records: compiler code

[Vicente Romero]

Hi,

I have uploaded another iteration to [2]. This one includes some missing 
type and annotation javax.lang.model visitors,

Thanks,
Vicente

[2] http://cr.openjdk.java.net/~vromero/records.review/compiler/webrev.05

On 11/8/19 5:02 PM, Vicente Romero wrote:
> Hi all,
>
> Please review another iteration of the compiler implementation for 
> records at [1]. New in this iteration:
>
> - I added an @implSpec comment to method: 
> javax.lang.model.util.Elements::recordComponentFor
> - moved the list of forbidden record component names to class Names
> - added the code proposed by Maurizio to the parser with a small tweak 
> for records declared as members
> - modified the error message to indicate that any non-canonical 
> constructor should invoke another constructor to: "constructor is not 
> canonical, so its first statement must invoke another constructor"
> - added method: 
> com.sun.tools.sjavac.comp.PubapiVisitor::visitRecordComponent
> - added new visitor: javax.lang.model.util.AbstractTypeVisitor14
> - moved annotation processing tests for records to common place for 
> other annotation processing tests
>
>
> Thanks,
> Vicente
>
> [1] http://cr.openjdk.java.net/~vromero/records.review/compiler/webrev.04