JDK 14 RFR of JDK-8233096: Update javax.lang.model for switch expressions

Joe Darcy joe.darcy at oracle.com
Tue Nov 12 23:37:28 UTC 2019


Coming back to this after the switch expression changes were pushed, 
I've updated the test to give a more informative output message on an error:

     http://cr.openjdk.java.net/~darcy/8233096.1/

and for completeness, a created an extra small CSR as well:

     https://bugs.openjdk.java.net/browse/JDK-8234055

Thanks,

-Joe

On 10/29/2019 11:28 AM, Joe Darcy wrote:
> On 10/29/2019 10:09 AM, Jonathan Gibbons wrote:
>>
>> Although not modified, is this line in the test as intended?
>>
>> 137             throw new RuntimeException("Unexpected " + message +  "-ness of _ on " + version);
>> The reference to "_" seems unexpected.
>
>
> Yeah; I noticed that too. It would clearly be more informative to 
> print out the input causing the failure. Code review feedback could 
> overcome my activation energy to do the small necessary refactoring ;-)
>
> -Joe
>
>
>>
>> -- Jon
>>
>> On 10/29/19 9:58 AM, Joe Darcy wrote:
>>> Hello,
>>>
>>> After switch expressions are added as a full non-preview feature 
>>> (JDK-8232684), portions of javax.lang.model should be updated 
>>> accordingly, including the description of SourceVersion.RELEASE_14.
>>>
>>> Please review the changes for this:
>>>
>>> http://cr.openjdk.java.net/~darcy/8233096.0/
>>>
>>> Thanks,
>>>
>>> -Joe
>>>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20191112/e5bb1dc2/attachment.html>


More information about the compiler-dev mailing list