RFR: JDK-8234687: change javap reporting on unknown attributes

[Jonathan Gibbons]

On 11/22/2019 04:09 PM, Mandy Chung wrote:
>
>
> On 11/22/19 4:01 PM, Jonathan Gibbons wrote:
>>
>>
>> On 11/22/19 3:39 PM, Mandy Chung wrote:
>>>
>>>
>>> On 11/22/19 3:24 PM, Jonathan Gibbons wrote:
>>>>
>>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8234687
>>>> Webrev: http://cr.openjdk.java.net/~jjg/8234687/webrev.00/
>>>>
>>> Looks okay to me.  About the test:
>>>
>>> 26 * @bug 8234687 Is it intentional to remove 8047072?
>>>
>>> Mandy
>>
>> Yes, this is a new test for this specific fix;  it's just that it was 
>> based on an earlier test.  Since it does not test the issue in 
>> 8047072, it does not seem appropriate to list that bug number.
>>
>> The old test (for BadAttributeLength) still exists without modification.
>>
>
> Looks good to me.
>
> Mandy

Thanks

-- Jon
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20191122/107e7d31/attachment.html>