RFR: JEP 359-Records: reflection code
Chris Hegarty
chris.hegarty at oracle.com
Tue Oct 22 12:44:14 UTC 2019
> On 21 Oct 2019, at 22:10, Vicente Romero <vicente.romero at oracle.com> wrote:
>
> Hi,
>
> Please review the reflection code for JEP 359 (Records) at [1]. There is a class here that is special [2] this contain the bootstrap methods for equals, hashCode and toString methods in records.
>
> Thanks in advance for the feedback,
> Vicente
>
> [1] http://cr.openjdk.java.net/~vromero/records.review/reflection/webrev.00/ <http://cr.openjdk.java.net/~vromero/records.review/reflection/webrev.00/>
A few minor comments to get out of the way:
1) missing license header, and
2) missing @since javadoc tag
Pushed to the records branch:
https://hg.openjdk.java.net/amber/amber/rev/31b6ebe43579
-Chris.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20191022/c80caf95/attachment.html>
More information about the compiler-dev
mailing list