JDK 14 RFR of JDK-8230626: Make UnknownFooException strings more informative

[Joe Darcy]

Updated webrev with patch below:

     http://cr.openjdk.java.net/~darcy/8230626.1/

-Joe

--- 
old/src/java.compiler/share/classes/javax/lang/model/element/UnknownAnnotationValueException.java 
2019-09-04 15:19:08.561963468 -0700
+++ 
new/src/java.compiler/share/classes/javax/lang/model/element/UnknownAnnotationValueException.java 
2019-09-04 15:19:08.385963468 -0700
@@ -60,7 +60,7 @@
       * @param p an additional parameter, may be {@code null}
       */
      public UnknownAnnotationValueException(AnnotationValue av, Object p) {
-        super("Unknown annotation value: " + av);
+        super("Unknown annotation value: \"" + av + "\"");
          this.av = av;
          this.parameter = p;
      }
--- 
old/src/java.compiler/share/classes/javax/lang/model/element/UnknownElementException.java 
2019-09-04 15:19:09.005963468 -0700
+++ 
new/src/java.compiler/share/classes/javax/lang/model/element/UnknownElementException.java 
2019-09-04 15:19:08.837963468 -0700
@@ -58,7 +58,7 @@
       * @param p an additional parameter, may be {@code null}
       */
      public UnknownElementException(Element e, Object p) {
-        super("Unknown element: " + e);
+        super("Unknown element: \"" + e + "\"");
          element = e;
          this.parameter = p;
      }
--- 
old/src/java.compiler/share/classes/javax/lang/model/type/UnknownTypeException.java 
2019-09-04 15:19:09.509963468 -0700
+++ 
new/src/java.compiler/share/classes/javax/lang/model/type/UnknownTypeException.java 
2019-09-04 15:19:09.305963468 -0700
@@ -58,7 +58,7 @@
       * @param p an additional parameter, may be {@code null}
       */
      public UnknownTypeException(TypeMirror t, Object p) {
-        super("Unknown type: " + t);
+        super("Unknown type: \"" + t + "\"");
          type = t;
          this.parameter = p;
      }

On 9/4/2019 3:04 PM, mark.reinhold at oracle.com wrote:
> 2019/9/4 14:19:00 -0700, joe.darcy at oracle.com:
>> Responding to some off-list input from Jon, please review the small
>> enhancement for
>>
>>    JDK-8230626: Make UnknownFooException strings more informative
>>    http://cr.openjdk.java.net/~darcy/8230626.0/
>>
>> Patch below; thanks,
>> ...
>> - super("Unknown annotation value: " + av);
>> + super("Unknown annotation value: ``" + av + "''");
> The use of GNU-style ``fake curly quotes'' in JDK messages is extremely
> rare, and jarring to the eye in most typefaces.  Pairs of backticks and
> apostrophes are a poorer subsitute for “true curly quotes” than simple
> "vertical quotation marks."  Please use vertical quotation marks, which
> is what we use pretty much everywhere.
>
> - Mark