RFR: JDK-8239544 : Javac does not respect should-stop.ifNoError policy to stop after CompileState PARSE, ENTER and PROCESS

[Jan Lahoda]

Looks Ok to me.

Jan

On 01. 04. 20 14:34, Adam Sotona wrote:
> Hi,
> Jan showed me a case where previous fix potentially hides deferred enter 
> errors and also proposed even less intrusive fix.
> new webrev: http://cr.openjdk.java.net/~asotona/8239544/webrev.02/
> 
> Mach5 build passes all Tier1, Tier2 and Tier3 tests
> 
> Thank you for the review,
> Adam
> 
>> On 26 Mar 2020, at 15:45, Adam Sotona <adam.sotona at oracle.com 
>> <mailto:adam.sotona at oracle.com>> wrote:
>>
>> Hi,
>> I've returned back to the issue and found the patch is affecting 
>> annotation processing negatively for cases of "recoverable" errors.
>> Here is slightly modified fix that does not cause premature stop 
>> before annotation processing in such specific situations.
>> Also the T823954.java test had to be written a bit more complex way to 
>> correctly test annotation processing stopping.
>>
>> new webrev: http://cr.openjdk.java.net/~asotona/8239544/webrev.01/
>>
>> Mach5 build passed Tier1, Tier2 and Tier3 tests (except for 
>> java/net/httpclient/FilePublisher/FilePublisherPermsTest.java, which 
>> seems to be unrelated).
>>
>> Thanks for your review,
>> Adam
>>
>>> On 24 Mar 2020, at 13:04, Jim Laskey <james.laskey at oracle.com 
>>> <mailto:james.laskey at oracle.com>> wrote:
>>>
>>> No problem. Just get one other reviewer.
>>>
>>>> On Mar 23, 2020, at 12:44 PM, Adam Sotona <adam.sotona at oracle.com 
>>>> <mailto:adam.sotona at oracle.com>> wrote:
>>>>
>>>> Hi,
>>>> I would like to ask you for review of the JavaCompiler patch fixing 
>>>> its response to should-stop.ifNoError= option for PARSE, ENTER and 
>>>> PROCESS compiler states.
>>>> The patch also includes new T8239544.java matrix regression test 
>>>> validating the compiler really stops at the requested states even 
>>>> under various compiler policies.
>>>> The most critical part of the fix was to do not affect existing 
>>>> (golden-file) tests expecting exact compiler errors and also do not 
>>>> affect MultiTaskListener expected behavior (and related tests).
>>>>
>>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8239544
>>>> webrev: http://cr.openjdk.java.net/~asotona/8239544/webrev.00/
>>>>
>>>> Mach5 build passed Tier1, Tier2 and Tier3 tests
>>>>
>>>> Thank you,
>>>> Adam
>>>>
>>>
>>
>