RFR: JDK-8230918: j.l.NASE in javap

[Vicente Romero]

Hi Jon,

Thanks for the review, I have updated the review to [1] to address your 
comments,

Vicente

[1] http://cr.openjdk.java.net/~vromero/8230918/webrev.01/



On 8/19/20 8:49 PM, Jonathan Gibbons wrote:
> Hi Vicente,
>
> It seems wrong to hijack an existing exception for an unrelated use.  
> There's no IO condition that warrants the use of 
> `java.io.IOException`. The problem is that for better or worse, javap 
> cannot handle this probably-malformed class file. That deserves some 
> appropriate exception, and a new one if there is nothing appropriate 
> that is already available to use.
>
> -- Jon
>
> On 8/19/20 5:24 PM, Vicente Romero wrote:
>> Please review fix for [1] at [2]. The fix is making javac fail with 
>> an error message if an attribute has a length too big to be processed.
>>
>> Thanks,
>> Vicente
>>
>> https://bugs.openjdk.java.net/browse/JDK-8230918
>> http://cr.openjdk.java.net/~vromero/8230918/webrev.00/