RFR: 8231622: SuppressWarning("serial") ignored on field serialVersionUID [v2]
Guoxiong Li
github.com+13688759+lgxbslgx at openjdk.java.net
Fri Dec 4 18:38:13 UTC 2020
On Fri, 4 Dec 2020 17:24:39 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:
>> Guoxiong Li has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Revise test cases. Remove legal header and add /nodynamiccopyright/
>
> For tests that use `/ref=file` `-XDrawDiagnostics` the conventions are:
>
> 1. Omit the complete legal header, including the copyright and license
> 2. After `@test` add the text `/nodynamiccopyright/`
>
> #1 protects the file against any future changes in the length of the legal header, that might affect line numbers, and #2 is for use by automated scripts that may check for the presence of the legal header.
Thank you for your comment. I revise my code according to your suggestion.
And I found some previous tests use the wrong style which are like this patch. I want to modify them so that these tests won't mislead other developers, especially the new developers. Could I get your help to open a new issue about it in the bug tracker? Thanks a lot.
-------------
PR: https://git.openjdk.java.net/jdk/pull/1626
More information about the compiler-dev
mailing list