RFR: 8256149: Weird AST structure for incomplete member select

[Vicente Romero]

On Wed, 11 Nov 2020 09:01:52 GMT, Jan Lahoda <jlahoda at openjdk.org> wrote:

> Consider code like:
> int i1 = "".
> @Deprecated
> void t1() {}
> 
> In current master, this will produce a somewhat twisted AST, and compile-time errors like:
> E.java:2: error: <identifier> expected
> int i = "".
>            ^
> E.java:3: error: illegal start of expression
> @Deprecated void t() {}
> ^
> E.java:3: error: ';' expected
> @Deprecated void t() {}
>            ^
> 3 errors
> 
> The reason is that `@Deprecated` is parsed as a type annotation following `"".<missing>`, which does not make much sense.
> 
> With this proposed patch, the AST is effectively the same as AST for:
> int i1 = "".; //note the semicolon here
> @Deprecated
> void t1() {}
> 
> And the errors are much better as well:
> E.java:2: error: <identifier> expected
> int i = "".
>            ^
> 1 error

looks good

-------------

Marked as reviewed by vromero (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/1159