[jdk16] RFR: JDK-8247994: Localize javadoc search

Jonathan Gibbons jjg at openjdk.java.net
Sun Dec 13 00:25:08 UTC 2020

On Sun, 13 Dec 2020 00:19:59 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

> This is for JDK16, as a precursor to fixing JDK-8258002.
> While it is good to be using localized strings in the generated output, the significance for JDK-8258002 is that the strings are now obtained from a resource file, and not hardcoded in JavaScript file itself.
> The source file `search.js` is renamed to `search.js.template`, and (unlike other template files) is copied as-is into the generated image. The values in the template are resolved when javadoc is executed, depending on the locale in use at the time. Because of the change in the file's extension, two makefiles are updated to accommodate the new extension: one is for the "interim" javadoc used to generate the API docs; the other is for the primary javadoc in the main JDK image.

make/CompileInterimLangtools.gmk line 77:

> 75:           Standard.java, \
> 76:       EXTRA_FILES := $(BUILDTOOLS_OUTPUTDIR)/gensrc/$1.interim/module-info.java, \
> 77:       COPY := .gif .png .xml .css .js .js.template .txt javax.tools.JavaCompilerTool, \

Build-folk: it would be nice if this macro could use `$(jdk.javadoc_COPY)` instead of having to duplicate entries.
(Future RFE?)


PR: https://git.openjdk.java.net/jdk16/pull/16

More information about the compiler-dev mailing list