RFR: 8255729: com.sun.tools.javac.processing.JavacFiler.FilerOutputStream is inefficient [v2]
Guoxiong Li
github.com+13688759+lgxbslgx at openjdk.java.net
Mon Dec 21 17:14:12 UTC 2020
> Hi all,
>
> `FilerOutputStream` extends `FilterOutputStream` without overwriting the method `write(byte b[], int off, int len)` which would suffer from the performance problem.
> This patch fixes it and adds some `@Override` to polish the code. But I can't find a good way to write a corresponding test case. Maybe it doesn't need a test case. And all existing tests in `test/langtools/tools/javac` passed locally.
>
> Thank you for taking the time to review.
>
> Best Regards.
Guoxiong Li has updated the pull request incrementally with one additional commit since the last revision:
Use Objects::checkFromIndexSize
-------------
Changes:
- all: https://git.openjdk.java.net/jdk/pull/1854/files
- new: https://git.openjdk.java.net/jdk/pull/1854/files/02a3fd1e..ed1d7320
Webrevs:
- full: https://webrevs.openjdk.java.net/?repo=jdk&pr=1854&range=01
- incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=1854&range=00-01
Stats: 2 lines in 1 file changed: 0 ins; 1 del; 1 mod
Patch: https://git.openjdk.java.net/jdk/pull/1854.diff
Fetch: git fetch https://git.openjdk.java.net/jdk pull/1854/head:pull/1854
PR: https://git.openjdk.java.net/jdk/pull/1854
More information about the compiler-dev
mailing list