[jdk16] RFR: 8258662: JDK 17ea: Crash compiling instanceof check involving sealed interface

Vicente Romero vromero at openjdk.java.net
Thu Dec 24 20:28:56 UTC 2020


On Wed, 23 Dec 2020 05:10:59 GMT, Guoxiong Li <github.com+13688759+lgxbslgx at openjdk.org> wrote:

> Hi all,
> 
> The method `Types.isCastable` uses method `Types.areDisjoint` to do some check. But `Types.isCastable` doesn't check the type of the parameter before invoking method `Types.areDisjoint`. This patch adds the corresponding check and add a test case.
> 
> The original patch is in https://github.com/openjdk/jdk/pull/1849.
> 
> Thank you for taking the time to review.
> 
> Best Regards.

looks good

-------------

Marked as reviewed by vromero (Reviewer).

PR: https://git.openjdk.java.net/jdk16/pull/63


More information about the compiler-dev mailing list