RFR: 8226216: parameter modifiers are not visible to javac plugins across compilation boundaries [v2]

Guoxiong Li github.com+13688759+lgxbslgx at openjdk.java.net
Fri Dec 25 08:24:57 UTC 2020


On Thu, 24 Dec 2020 16:18:55 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

>> Guoxiong Li has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Modify legal header. Fix typo.
>
> test/langtools/tools/javac/classreader/8226216/T8226216.java line 9:
> 
>> 7:  * published by the Free Software Foundation.  Oracle designates this
>> 8:  * particular file as subject to the "Classpath" exception as provided
>> 9:  * by Oracle in the LICENSE file that accompanied this code.
> 
> Tests should not contain the text `Oracle designates ... this code.` or the immediately preceding whitespace.

Fixed.

> test/langtools/tools/javac/classreader/8226216/T8226216.java line 123:
> 
>> 121: 
>> 122:     @Test
>> 123:     public void testParameterModifiersNotVisiable() throws Exception {
> 
> spelling: should be "Visible"

Fixed.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1890


More information about the compiler-dev mailing list