RFR: 8216400: improve handling of IOExceptions in JavaCompiler.close() [v2]
Guoxiong Li
github.com+13688759+lgxbslgx at openjdk.java.net
Sat Dec 26 15:46:15 UTC 2020
> Hi all,
>
> This little patch enhances the code according to the comment by using a simplest way. I found [JDK-8069116](https://bugs.openjdk.java.net/browse/JDK-8069116) is a similar issue. A better way would be appreciated.
>
> Thank you for taking the time to reivew.
>
> Best Regards.
Guoxiong Li has updated the pull request incrementally with two additional commits since the last revision:
- Add a test case.
- Set all exceptions from all the Closeables.
-------------
Changes:
- all: https://git.openjdk.java.net/jdk/pull/1895/files
- new: https://git.openjdk.java.net/jdk/pull/1895/files/5e844d0c..e19b1a22
Webrevs:
- full: https://webrevs.openjdk.java.net/?repo=jdk&pr=1895&range=01
- incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=1895&range=00-01
Stats: 155 lines in 2 files changed: 152 ins; 0 del; 3 mod
Patch: https://git.openjdk.java.net/jdk/pull/1895.diff
Fetch: git fetch https://git.openjdk.java.net/jdk pull/1895/head:pull/1895
PR: https://git.openjdk.java.net/jdk/pull/1895
More information about the compiler-dev
mailing list