RFR: 8198317: Enhance JavacTool.getTask for flexibility [v3]

Jonathan Gibbons jjg at openjdk.java.net
Tue Dec 29 03:45:58 UTC 2020

On Tue, 29 Dec 2020 03:40:52 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

>> Guoxiong Li has updated the pull request incrementally with one additional commit since the last revision:
>>   Revise test.
> Any time that tests split a string into lines it is really important to ensure that it works on Windows as well as Linux/Mac platforms, because of the different line endings.
> The code looks OK. Alternatively, if you are not concerned to check for the exact line ending sequence, you can use `split("\\R")` to split on any line ending sequence.  Either way, it's worth checking the test runs on platforms with both kinds of typical line ending.

Given that the `langtools/tier1` pre-submit tests worked for Linux and Windows, you're OK on the "newline" front.


PR: https://git.openjdk.java.net/jdk/pull/1896

More information about the compiler-dev mailing list