RFR: 8173165: javac should reject references to enum constants from nested classes inside instance initializers

[Guoxiong Li]

On Tue, 29 Dec 2020 11:19:11 GMT, Guoxiong Li <github.com+13688759+lgxbslgx at openjdk.org> wrote:

> Hi all,
> 
> The [JLS 8.9.2](https://docs.oracle.com/javase/specs/jls/se15/html/jls-8.html#jls-8.9.2) states it as bellow.
> 
>> It is a compile-time error to refer to a static field of an enum type from a constructor, instance initializer, or instance variable initializer of the enum type, unless the field is a constant variable (§4.12.4).
> 
> Currently, compiler doesn't generate the compile-time error when compiling the following code.
> 
> import java.util.HashSet;
> public enum Test {
>     FOO;
>     public HashSet<Test> vals = new HashSet<Test>(){
>         Test test = FOO;
>         {
>             add(FOO);
>         }
>     };
> }
> 
> This patch fixes it and adds two corresponding tests. Thank you for taking the time to review.
> 
> Best Regards.

The bug is more complicated than I thought. I would like to close the PR and let another person fix it.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1905