RFR: 8255757: Javac emits duplicate pool entries on array::clone [v2]

Guoxiong Li github.com+13688759+lgxbslgx at openjdk.java.net
Thu Dec 31 16:03:16 UTC 2020


On Thu, 31 Dec 2020 15:31:38 GMT, Vicente Romero <vromero at openjdk.org> wrote:

>> Guoxiong Li has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Cleanup variable and useless test code.
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/jvm/Gen.java line 2433:
> 
>> 2431:             endPosTable = null;
>> 2432:             nerrs = 0;
>> 2433:             qualifiedSymbolCache = null;
> 
> I meant `qualifiedSymbolCache.clear()` instead of assigning null to it

If we use `qualifiedSymbolCache.clear()`, maybe it is good to remove the following code currently. 

if (qualifiedSymbolCache == null) {
                qualifiedSymbolCache = new HashMap<>();
}

If the `qualifiedSymbolCache` is revised elsewhere in the future, more attention should be paid.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1912


More information about the compiler-dev mailing list