RFR: 8255757: Javac emits duplicate pool entries on array::clone [v3]

Guoxiong Li github.com+13688759+lgxbslgx at openjdk.java.net
Thu Dec 31 16:50:23 UTC 2020


On Thu, 31 Dec 2020 16:31:33 GMT, Vicente Romero <vromero at openjdk.org> wrote:

>> Guoxiong Li has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Use Map::clear
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/jvm/Gen.java line 47:
> 
>> 45: import com.sun.tools.javac.tree.JCTree.*;
>> 46: 
>> 47: import java.util.HashMap;
> 
> sorry one final matter of style these imports should come first before all the `com.sun.tools.javac.*` ones, there is no need for another review iteration just please fix it before integrating. Thanks!

Fixed.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1912


More information about the compiler-dev mailing list