RFR: JDK-8235352: java.lang.runtime.package-info should be annotated with @PreviewFeature

[Jonathan Gibbons]

Vicente,

A qualified-OK.

I find it curious to declare the package as a preview feature, as 
compared to the class in it. I agree that ObjectMethods should be so 
marked, so there is no issue there.

So my OK is conditional on there being some decision recorded somewhere 
that we want to do this;  if there is such a decision, then I agree you 
have implemented the decision in an acceptable way.

-- Jon

On 1/8/20 2:58 PM, Vicente Romero wrote:
> ok good, are you OK with the change?
>
> Vicente
>
> On 1/8/20 5:16 PM, Jonathan Gibbons wrote:
>> Yeah, that's the specdiff, not the underlying API, but I can see the 
>> info I was looking for. Thanks.
>>
>> -- Jon
>>
>> On 1/8/20 2:13 PM, Vicente Romero wrote:
>>> sure, please find it at [1]
>>>
>>> Thanks,
>>> Vicente
>>>
>>> [1] http://cr.openjdk.java.net/~vromero/8235352/specdiff.runtime/
>>>
>>> On 1/8/20 4:17 PM, Jonathan Gibbons wrote:
>>>> Vicente,
>>>>
>>>> Given that you have put the {@preview} at the beginning, how well 
>>>> does this interact with javadoc and javadoc's handling of the first 
>>>> sentence in summary contexts? Could you generate docs and post the 
>>>> API bundle along with the webrev.
>>>>
>>>> -- Jon
>>>>
>>>>
>>>> On 01/08/2020 01:11 PM, Vicente Romero wrote:
>>>>> Please review this simple fix which is adding the @PreviewFeature 
>>>>> and related doc to, new for records, file 
>>>>> java/lang/runtime/package-info.java. Webrev is at [1] and JIRA 
>>>>> issue at [2]
>>>>>
>>>>> Thanks,
>>>>> Vicente
>>>>>
>>>>> [1] http://cr.openjdk.java.net/~vromero/8235352/webrev.00/
>>>>> [2] https://bugs.openjdk.java.net/browse/JDK-8235352
>>>>
>>>
>