RFR(XS): 8237601: test/langtools/tools/javac/warnings/MaxDiagsRecompile.java fails after JDK-8237589
David Holmes
david.holmes at oracle.com
Wed Jan 22 01:34:24 UTC 2020
Looks good to me - and trivial.
Thanks,
David
>> On Jan 21, 2020, at 3:58 PM, Mikael Vidstedt <mikael.vidstedt at
oracle.com> wrote:
> tools/javac/warnings/MaxWarnsRecompile.java needs the same kind of fix. New webrev:
>
> full: http://cr.openjdk.java.net/~mikael/webrevs/8237601/webrev.01/open/webrev/
> incremental: http://cr.openjdk.java.net/~mikael/webrevs/8237601/webrev.01.incr/open/webrev/ <http://cr.openjdk.java.net/~mikael/webrevs/8237601/webrev.01.incr/open/webrev/>
>
> Cheers,
> Mikael
>
>> On Jan 21, 2020, at 3:58 PM, Mikael Vidstedt <mikael.vidstedt at oracle.com> wrote:
>>
>>
>> Please review this small change which fixes the “golden” files used by the MaxDiagsRecompile test. JDK-8237589 updated the file header, shifting all the line numbers by 4.
>>
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8237601 <https://bugs.openjdk.java.net/browse/JDK-8237601>
>> webrev: http://cr.openjdk.java.net/~mikael/webrevs/8237601/webrev.00/open/webrev/ <http://cr.openjdk.java.net/~mikael/webrevs/8237601/webrev.00/open/webrev/>
>>
>> Cheers,
>> Mikael
>>
More information about the compiler-dev
mailing list