RFR: JDK-8236997 tools/javac tests fail with --illegal-access=deny

Jan Lahoda jan.lahoda at oracle.com
Fri Jan 24 14:04:46 UTC 2020

Overall, looks fine to me. A few comments:
-in test/langtools/tools/javac/classwriter/ExtraAttributes.java, calling 
.options several times will clear the values set by previous 
invocations. The plugin here will start as it is an autostart plugin, so 
I guess I'd suggest to remove the first call to .options, as the first 
call is not really needed

-in test/langtools/tools/javac/failover/CheckAttributedTree.java, I 
would suggest to return back the "java.desktop" after "@modules". It is 
not needed to compile or run the test itself, but the test is trying to 
compile all other tests as well, and "java.desktop" will prevent 
attempts to run the test on limited JDKs without java.desktop (which is 

-I am afraid there is another test using the combo test framework in the 
jdk (as opposed to langtools) tests:

That one should receive the same handling as the other combo tests (this 
is the only test outside of langtools I was able to find).


On 23. 01. 20 17:13, Adam Sotona wrote:
> Hi,
> I would like to ask for review of tools/javac tests patch (attached) so 
> the tests work correctly with --illegal-access=deny switch.
> JBS: https://bugs.openjdk.java.net/browse/JDK-8236997
> Please let me know if this is OK or if there are any issues with the 
> proposed patch.
> Thank you,
> Adam

More information about the compiler-dev mailing list